[webkit-reviews] review denied: [Bug 94801] MediaStream API: Add toString to RTCIceCandidate and RTCSessionDescription : [Attachment 160139] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 94801: MediaStream API: Add toString to RTCIceCandidate and
RTCSessionDescription
https://bugs.webkit.org/show_bug.cgi?id=94801

Attachment 160139: Patch
https://bugs.webkit.org/attachment.cgi?id=160139&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160139&action=review


> Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp:93
> +    String result = "({candidate:\"" + candidate() + "\",sdpMid:\"" +
sdpMid() + "\",sdpMLineIndex:" + String::number(sdpMLineIndex()) + "})";

Is this meant to be JSON?  (This isn't valid JSON.)  Also sdpMid() can be an
arbitrary string, right?  That means it might include a " and break the format
of the string.

Perhaps we should use InspectorValue to create valid JSON?