[webkit-reviews] review granted: [Bug 36427] XPathEvaluator returns document root for "/" when the context node is in a detached subtree (unlike Firefox) : [Attachment 160069] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Chris Evans
<cevans at google.com>'s request for review:
Bug 36427: XPathEvaluator returns document root for "/" when the context node
is in a detached subtree (unlike Firefox)
https://bugs.webkit.org/show_bug.cgi?id=36427

Attachment 160069: Patch
https://bugs.webkit.org/attachment.cgi?id=160069&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160069&action=review


Thank you!

> Source/WebCore/xml/XPathPath.cpp:101
> +    // "/ selects the document root (which is always the parent of the
> +    // document element)"
> +    // "A / by itself selects the root node of the document containing the
> +    // context node."

We don't need to make lines this short, it's normal to have much longer lines
in WebKit.

> Source/WebCore/xml/XPathPath.cpp:104
> +    // This is for compatability with Firefox, and also seems like a more

Typo: should be "compatibility".