[webkit-reviews] review granted: [Bug 94448] Array accesses should remember what kind of array they are predicted to access : [Attachment 160041] the patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 94448: Array accesses should remember what kind of array they are predicted
to access
https://bugs.webkit.org/show_bug.cgi?id=94448

Attachment 160041: the patch
https://bugs.webkit.org/attachment.cgi?id=160041&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160041&action=review


> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:151
> +		       for (unsigned n = 2; n--;)

why? - please to be commenting.

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:328
> +	   case PutByVal: {

case PutByValAlias:

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:344
>		   if (m_graph[child3].shouldSpeculateInteger())

if (!condition) fixDoubleEdge