[webkit-reviews] review requested: [Bug 94761] ThreadRestrictionVerifier should be opt-in, not opt-out : [Attachment 160047] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has asked  for review:
Bug 94761: ThreadRestrictionVerifier should be opt-in, not opt-out
https://bugs.webkit.org/show_bug.cgi?id=94761

Attachment 160047: Patch
https://bugs.webkit.org/attachment.cgi?id=160047&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160047&action=review


This change appears to make it easier for JSC code to turn this off which is
good.

How does the rest of the code continue to get the benefit from this
automatically as it has in the past? (There have been several issues uncovered
by this which would have resulted in hard to figure out memory corruptions.)

> Source/WTF/ChangeLog:23
> +	   to maintain with default off, so I removed them.

Actually they aren't. They simply assert that the method calls were only made
when the class was in its initial state.  It is only the change to make m_mode
NoVerificationMode that makes them fire.