[webkit-reviews] review denied: [Bug 80394] CSS 2.1 failure: margin-collapse-clear-012 fails : [Attachment 153702] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 80394: CSS 2.1 failure: margin-collapse-clear-012 fails
https://bugs.webkit.org/show_bug.cgi?id=80394

Attachment 153702: Patch
https://bugs.webkit.org/attachment.cgi?id=153702&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=153702&action=review


> Source/WebCore/rendering/RenderBlock.cpp:2061
> +	   marginInfo.setCanCollapseMarginAfterWithChildren(false);

This line seems wrong to me. What if another sibling is encountered? You've
permanently turned off collapsing the parent with the child. If another normal
block child comes along after this self-collapsing one, you'll mess up because
you set this bit, won't you?

That's the reason for the lookahead to figure out if we're really at the bottom
of the block.. the lookahead you removed.

Basically to fix the bug it seems like all you had to fix was the
setLogicalHeight line, no? The other code was fine.