[webkit-reviews] review granted: [Bug 94170] Allow blocking of Web SQL databases in third-party web workers : [Attachment 159256] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Jeffrey Pfau <jeffrey at endrift.com>'s
request for review:
Bug 94170: Allow blocking of Web SQL databases in third-party web workers
https://bugs.webkit.org/show_bug.cgi?id=94170

Attachment 159256: Patch
https://bugs.webkit.org/attachment.cgi?id=159256&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159256&action=review


I still think this patch is ugly, but I don't see a better way of solving this
problem.

> Source/WebCore/workers/WorkerMessagingProxy.cpp:285
>									   
m_scriptExecutionContext->contentSecurityPolicy()->deprecatedHeader(),
> -									   
m_scriptExecutionContext->contentSecurityPolicy()->deprecatedHeaderType());
> +									   
m_scriptExecutionContext->contentSecurityPolicy()->deprecatedHeaderType(),
> +									   
document->topDocument()->securityOrigin());

I would have changed these all to use |document| to be clear that we're getting
all this information from the same place.