[webkit-reviews] review granted: [Bug 94537] Setting WebKitEnableHTTPPipelining doesn't work if default is true : [Attachment 159546] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 94537: Setting WebKitEnableHTTPPipelining doesn't work if default is true
https://bugs.webkit.org/show_bug.cgi?id=94537

Attachment 159546: Patch
https://bugs.webkit.org/attachment.cgi?id=159546&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159546&action=review


r=me with comments addressed.

> Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp:278
> +    Boolean keyExistsAndHasValidFormat;

Nit:  Initialize to False.

> Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp:281
> +    bool pipeliningEnabled = keyExistsAndHasValidFormat ? prefValue :
ResourceRequest::httpPipeliningEnabled();
> +    ResourceRequest::setHTTPPipeliningEnabled(pipeliningEnabled);

This could be simplified to this (as mentioned in Comment #6):

    if (keyExistsAndHasValidFormat)
	ResourceRequest::setHTTPPipeliningEnabled(prefValue);