[webkit-reviews] review granted: [Bug 88583] Update the TextTrackCue Constructor : [Attachment 159967] adding check for NaN

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 88583: Update the TextTrackCue Constructor
https://bugs.webkit.org/show_bug.cgi?id=88583

Attachment 159967: adding check for NaN
https://bugs.webkit.org/attachment.cgi?id=159967&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=159967&action=review


> Source/WebCore/html/track/TextTrackCue.cpp:92
> +    : m_id(emptyString())

I don't think we need to distinguishable between a null and an empty string so
this should be unnecessary.

> Source/WebCore/html/track/TextTrackCue.h:93
> +    void parseSettings(const String&);

parseSettings was OK as a private method name but not so much as public method
name because, for example, we don't necessarily need to parse the settings
string immediately (although we do now) . The spec talks about "WebVTT cue
settings" so how about "setCueSettings" instead?