[webkit-reviews] review denied: [Bug 94722] [BlackBerry] Add a check to filter out cookies that tries to set the domain to a top level domain : [Attachment 159958] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied otcheung at rim.com's request for review:
Bug 94722: [BlackBerry] Add a check to filter out cookies that tries to set the
domain to a top level domain
https://bugs.webkit.org/show_bug.cgi?id=94722

Attachment 159958: Patch
https://bugs.webkit.org/attachment.cgi?id=159958&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=159958&action=review


Looks good, needs some cleanup still.

> Source/WebCore/ChangeLog:2
> +

Remove one empty line here.

> Source/WebCore/ChangeLog:11
> +	   If it is, throw it out when parsing

Lacks a period at the end.

> Source/WebCore/ChangeLog:18
> +	   and launcher commit.

This seems not relevant here. I think it is better when adding the unit test to
refer to this bug.