[webkit-reviews] review granted: [Bug 84291] [BlackBerry] MediaPlayerPrivate should not reference HTMLMediaElement directly : [Attachment 159946] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted John Griggs
<jgriggs at rim.com>'s request for review:
Bug 84291: [BlackBerry] MediaPlayerPrivate should not reference
HTMLMediaElement directly
https://bugs.webkit.org/show_bug.cgi?id=84291

Attachment 159946: Patch
https://bugs.webkit.org/attachment.cgi?id=159946&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=159946&action=review


Marking r+, but I would like to see the size methods change noted.

> Source/WebCore/platform/graphics/MediaPlayer.h:196
> +    virtual void mediaPlayerSetSize(int, int) { }

Every spatial "setSize" in WebCore (except one) takes a size class rather than
a pair of unit values. Using ints is fine, but you should really pass the value
as an IntSize:

    virtual void mediaPlayerSetSize(const IntSize&) { }