[webkit-reviews] review granted: [Bug 94705] Web Inspector: make "sdk" component compile independently from the rest of the front-end. : [Attachment 159938] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 94705: Web Inspector: make "sdk" component compile independently from the
rest of the front-end.
https://bugs.webkit.org/show_bug.cgi?id=94705

Attachment 159938: Patch
https://bugs.webkit.org/attachment.cgi?id=159938&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159938&action=review


> Source/WebCore/inspector/front-end/DOMStorage.js:163
> +	       payload.isLocalStorage))

;

> Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:-195
> -var InspectorFrontendHost = new WebInspector.InspectorFrontendHostStub();

Why?

> Source/WebCore/inspector/front-end/ResourcesPanel.js:366
> +	       this._showDOMStorage(domStorage);

Can we remove it like showDatabase was removed?

> Source/WebCore/inspector/front-end/ScriptsPanel.js:395
> +	   WebInspector.searchController.disableSearchUntilExplicitAction();

Why did this change?