[webkit-reviews] review denied: [Bug 94696] Web Inspector: [WebGL] Simple experimental frontend implementation : [Attachment 159917] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 22 08:05:13 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 94696: Web Inspector: [WebGL] Simple experimental frontend implementation
https://bugs.webkit.org/show_bug.cgi?id=94696

Attachment 159917: Patch
https://bugs.webkit.org/attachment.cgi?id=159917&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159917&action=review


> Source/WebCore/WebCore.gypi:6389
> +	       'inspector/front-end/WebGLPanel.js',

This panel should not be a part of the core, please load WebGLPanel as a module
(lazily).

> Source/WebCore/inspector/front-end/inspector.html:161
> +    <script type="text/javascript" src="WebGLPanel.js"></script>

Should be a module.


More information about the webkit-reviews mailing list