[webkit-reviews] review granted: [Bug 91812] Implement UndoManager's automatic DOM transactions : [Attachment 159848] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 21 20:37:40 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Sukolsak Sakshuwong
<sukolsak at google.com>'s request for review:
Bug 91812: Implement UndoManager's automatic DOM transactions
https://bugs.webkit.org/show_bug.cgi?id=91812

Attachment 159848: Patch
https://bugs.webkit.org/attachment.cgi?id=159848&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159848&action=review


> Source/WebCore/bindings/v8/DOMTransaction.cpp:80
> +    else {
> +	   for (size_t i = m_transactionSteps.size(); i > 0; --i)
> +	       m_transactionSteps[i - 1]->unapply();
> +    }

It'll be nice if we can share this code with JSC implementation.


More information about the webkit-reviews mailing list