[webkit-reviews] review granted: [Bug 94237] Fix cross-direction stretch for replaced elements in row flexbox : [Attachment 159771] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Shezan Baig
<shezbaig.wk at gmail.com>'s request for review:
Bug 94237: Fix cross-direction stretch for replaced elements in row flexbox
https://bugs.webkit.org/show_bug.cgi?id=94237

Attachment 159771: Patch
https://bugs.webkit.org/attachment.cgi?id=159771&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159771&action=review


> Source/WebCore/rendering/RenderFlexibleBox.cpp:1237
> +	   if (!hasOrthogonalFlow(child)) {

Good catch! I think we just need to use the overrideHeight if it is set and use
logicalHeight otherwise.

Similarly, when we make the column flow case first check if the width is
changing, if hasOrthogonalFlow(child) is false, we'll need to grab the override
width if it exists.

In either case, both of these can be followup patches.