[webkit-reviews] review granted: [Bug 21898] Remove unused TextDrawingMode flags from GraphicsContext : [Attachment 159678] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 21 17:15:31 PDT 2012


Benjamin Poulain <benjamin at webkit.org> has granted Caio Marcelo de Oliveira
Filho <cmarcelo at webkit.org>'s request for review:
Bug 21898: Remove unused TextDrawingMode flags from GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=21898

Attachment 159678: Patch
https://bugs.webkit.org/attachment.cgi?id=159678&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159678&action=review


Looks good, grep does not find those values used anywhere.

> Source/WebCore/platform/graphics/GraphicsContext.h:-134
> -	   TextModeInvisible = 0,
>	   TextModeFill      = 1 << 0,
>	   TextModeStroke    = 1 << 1,
> -	   TextModeClip      = 1 << 2

Why not shift the values?
TextModeFill = 0,
TextModeStroke = 1 << 0


More information about the webkit-reviews mailing list