[webkit-reviews] review granted: [Bug 72811] [Gtk] No accessible caret-moved events found in certain content : [Attachment 159791] Fix for the failure to implement AtkText along with updated unit test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 21 16:22:06 PDT 2012
chris fleizach <cfleizach at apple.com> has granted Joanmarie Diggs
<jdiggs at igalia.com>'s request for review:
Bug 72811: [Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811
Attachment 159791: Fix for the failure to implement AtkText along with updated
unit test
https://bugs.webkit.org/attachment.cgi?id=159791&action=review
------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=159791&action=review
> Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:820
> + return (role == ParagraphRole || role == HeadingRole || role == DivRole
|| role == CellRole);
i think the parens around the statement are not necessary. i'm not sure if
there is a style guide entry about this
More information about the webkit-reviews
mailing list