[webkit-reviews] review denied: [Bug 94364] Add saturation arithmetic support to FractionalLayoutUnit : [Attachment 159759] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 94364: Add saturation arithmetic support to FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=94364

Attachment 159759: Patch
https://bugs.webkit.org/attachment.cgi?id=159759&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
> > If I do saturatedAddition(0, -1), the result would be 1?.
> 
> No, it'll be -1. See the attached test case.

Of course, my bad. For some reason I thought the return was unsigned or
something...

I r- for the tests and because IMHO, this does not belong in MathExtras.h
(maybe CheckedArithmetic.h or a new SaturatedArithmetic.h?).