[webkit-reviews] review requested: [Bug 94237] Fix cross-direction stretch for replaced elements in row flexbox : [Attachment 159771] Patch

[bugzilla-daemon at webkit.org]

Shezan Baig <shezbaig.wk at gmail.com> has asked  for review:
Bug 94237: Fix cross-direction stretch for replaced elements in row flexbox
https://bugs.webkit.org/show_bug.cgi?id=94237

Attachment 159771: Patch
https://bugs.webkit.org/attachment.cgi?id=159771&action=review

------- Additional Comments from Shezan Baig <shezbaig.wk at gmail.com>
I think this patch requires another review.  I had to disable stretching when
the child and the flexbox had orthogonal flows, in order to make the tests
above pass.  The issue here is that the child already gets overrideHeight set
during the flex layout, so we can't use overrideHeight for stretching.	I'm not
sure what to do here (do we use overrideWidth instead in this case?).  I've
added a FIXME for this, so hopefully it can be addressed in a future patch.