[webkit-reviews] review granted: [Bug 94631] [chromium] Should be able to destroy a CCLayerTreeHost without manually setting the root layer : [Attachment 159752] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 94631: [chromium] Should be able to destroy a CCLayerTreeHost without
manually setting the root layer
https://bugs.webkit.org/show_bug.cgi?id=94631

Attachment 159752: Patch
https://bugs.webkit.org/attachment.cgi?id=159752&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
(In reply to comment #3)
> What I meant is CCLayerTreeHost is OwnPtr<>, not RefCounted. Maybe I should
rewrite that?

Yeah, I guess "has single ownership" (ambiguous "...of something else") vs.
"has a single owner".  I don't feel too strongly about it.

> LayerChromium::setLayerTreeHost() is recursive - it'll set the
m_layerTreeHost to 0 for all layers under the root (including mask/replicas)

Oh, quite right.  I was misremembering.  This seems totally fine.  R=me.