[webkit-reviews] review granted: [Bug 94625] Create CSS color output string on 8 bits : [Attachment 159735] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 94625: Create CSS color output string on 8 bits
https://bugs.webkit.org/show_bug.cgi?id=94625

Attachment 159735: Patch
https://bugs.webkit.org/attachment.cgi?id=159735&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159735&action=review


r=me

> Source/WebCore/css/CSSPrimitiveValue.cpp:1011
> +	       bool colorHasAlpha = color.hasAlpha();

Does this really need a local variable?

> Source/WebCore/css/CSSPrimitiveValue.cpp:1029
> +		   NumberToStringBuffer buffer;
> +		   const char* alphaString =
numberToFixedPrecisionString(color.alpha() / 255.0f, 6, buffer, true);
> +		   result.append(alphaString, strlen(alphaString));

Too bad we need the strlen() here.