[webkit-reviews] review granted: [Bug 94621] [BlackBerry] Add option to only add JavaScript object 'qnx' to private webviews : [Attachment 159741] patch

[bugzilla-daemon at webkit.org]

Yong Li <yoli at rim.com> has granted Benjamin Meyer <ben at meyerhome.net>'s request
for review:
Bug 94621: [BlackBerry] Add option to only add JavaScript object 'qnx' to
private webviews
https://bugs.webkit.org/show_bug.cgi?id=94621

Attachment 159741: patch
https://bugs.webkit.org/attachment.cgi?id=159741&action=review

------- Additional Comments from Yong Li <yoli at rim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=159741&action=review


>> Source/WebKit/blackberry/Api/WebPage.h:387
>> +	void enableQnxJavaScriptObject(bool);
> 
> Naming:
> 1. Qnx should be QNX
> 2. WebKit usually use setFooEnabled(boo)

hm.. probably Qnx is ok because the js object is "qnx"