[webkit-reviews] review granted: [Bug 90085] [GTK] Using a native window for the WebView breaks GtkOverlay : [Attachment 159728] Patch

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 90085: [GTK] Using a native window for the WebView breaks GtkOverlay
https://bugs.webkit.org/show_bug.cgi?id=90085

Attachment 159728: Patch
https://bugs.webkit.org/attachment.cgi?id=159728&action=review

------- Additional Comments from Alejandro G. Castro <alex at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=159728&action=review


Great patch, LGTM. This seems the way to go.

> Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp:66
> +    m_parentWindow = XCreateWindow(display,
> +				      RootWindow(display,
DefaultScreen(display)),
> +				       -100, -100, 1, 1,
> +				       0,
> +				       CopyFromParent,
> +				       InputOutput,
> +				       CopyFromParent,
> +				       CWOverrideRedirect,
> +				       &windowAttributes);

Indent typo.

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h:-81
> -#if USE(TEXTURE_MAPPER_GL)
>      WebCore::GLContext* glContext();
>      OwnPtr<WebCore::GLContext> m_context;
>  #endif
> -#endif

Why do you remove this #if?

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp:193
> +    // called. For non-animation situations we use this terrible hack until
we can get to the

Trailing whitespace in horrible hack comment ;).

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp:216
> +    // to update. This isn't a problem during animations, because swapBuffer
is continuously 

Ditto.

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp:348
> +    //    return;

I guess this is a leftover.