[webkit-reviews] review granted: [Bug 94616] [New Multicolumn] Get column rules painting : [Attachment 159721] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 94616: [New Multicolumn] Get column rules painting
https://bugs.webkit.org/show_bug.cgi?id=94616

Attachment 159721: Patch
https://bugs.webkit.org/attachment.cgi?id=159721&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=159721&action=review


> Source/WebCore/ChangeLog:11
> +	   No new tests (OOPS!).

OOPS! Are ref tests possible? Would be good to test rule painting with mixed
writing modes.

> Source/WebCore/rendering/RenderMultiColumnBlock.h:46
> +    RenderMultiColumnFlowThread* flowThread() const { return m_flowThread; }


Should it return a const RenderMultiColumnFlowThread*?

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:65
> +int RenderMultiColumnSet::columnGap() const

This doesn't need to return a LayoutUnit?

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:69
> +    return static_cast<int>(style()->columnGap());

Maybe use pixelSnap, or make the rounding mode more explicit?

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:72
> +LayoutRect RenderMultiColumnSet::columnRectAt( unsigned index) const

Space after (

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:74
> +    // Compute the appropriate rect based off our information.

Not sure that this comment adds anything.