[webkit-reviews] review denied: [Bug 94211] getComputedStyle returns wrong value for CSS3 2D transformations : [Attachment 159667] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Alexander Shalamov
<alexander.shalamov at gmail.com>'s request for review:
Bug 94211: getComputedStyle returns wrong value for CSS3 2D transformations
https://bugs.webkit.org/show_bug.cgi?id=94211

Attachment 159667: Patch
https://bugs.webkit.org/attachment.cgi?id=159667&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=159667&action=review


I thought you were going to fix transform-origin too?

> LayoutTests/ChangeLog:8
> +	   This change will fix getComputedStyle-transform.html test.

s/will fix/fixes.

> LayoutTests/ChangeLog:12
> +	   Currently, the test doesn't do anything. When new transformation
> +	   value is set, it immediately read back as an old value, thus
> +	   computed style is equal to an old style. Moreover, expected
> +	   result is never checked.

Using 'currently' in a changelog is ambiguous. Does it refer to the state
before or after the change? I'd say "before this change, the test didn't do
anything".