[webkit-reviews] review requested: [Bug 94237] Fix cross-direction stretch for replaced elements in row flexbox : [Attachment 159707] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 21 09:58:13 PDT 2012
Shezan Baig <shezbaig.wk at gmail.com> has asked for review:
Bug 94237: Fix cross-direction stretch for replaced elements in row flexbox
https://bugs.webkit.org/show_bug.cgi?id=94237
Attachment 159707: Patch
https://bugs.webkit.org/attachment.cgi?id=159707&action=review
------- Additional Comments from Shezan Baig <shezbaig.wk at gmail.com>
New patch with new logicalHeightConstrainedByMinMax() helper method. I would
have liked to make this a "const" method, but it is using some methods that are
currently non-const, and when trying to convert those, I ended up going down a
wormhole of const-correcting. Perhaps this can be addressed in a future patch.
More information about the webkit-reviews
mailing list