[webkit-reviews] review denied: [Bug 94598] [V8] Move reportUnsafeAccessTo() from V8Proxy to BindingSecurity : [Attachment 159685] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Kentaro Hara <haraken at chromium.org>'s
request for review:
Bug 94598: [V8] Move reportUnsafeAccessTo() from V8Proxy to BindingSecurity
https://bugs.webkit.org/show_bug.cgi?id=94598

Attachment 159685: Patch
https://bugs.webkit.org/attachment.cgi?id=159685&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159685&action=review


This isn't quite right.  BindingSecurity.cpp is part of the "generic bindings",
which means it's shared by JavaScriptCore and V8.  JavaScriptCore has a much
better implementation of this function.  I'd like to delete the V8
implementation and share the better JSC implementation.  I'll try to get that
done in the next day or two.

> Source/WebCore/bindings/generic/BindingSecurity.cpp:86
> +    Frame* source = firstFrame(BindingState::instance());

The proximate problem is that you can't use BindingState::instance() outside of
V8 because in JavaScriptCore, BindingState is the ExecState and JavaScriptCore
doesn't keep the ExecState in a static the same way that V8 does.