[webkit-reviews] review denied: [Bug 94527] Remove RenderView::layoutDelta() now that it's no longer needed : [Attachment 159635] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Eric Seidel <eric at webkit.org>'s request
for review:
Bug 94527: Remove RenderView::layoutDelta() now that it's no longer needed
https://bugs.webkit.org/show_bug.cgi?id=94527

Attachment 159635: Patch
https://bugs.webkit.org/attachment.cgi?id=159635&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
There are a few things making me uncomfortable about this (and I really think
we want Dan's input here).

(1) You have a bunch of results that are repainting tightly now overpainting.
These test cases are obviously regressing.

(2) I'm not convinced the one multi-pass spot you patched is good enough. We
have numerous other places where we do multi-pass layout. Do they all have to
be patched? If they do all have to be patched, is that the precise problem
layoutDelta was trying to solve?

I think we absolutely need to get Dan's input here, since he seems to be the
only one who knows what layoutDelta's purpose really is.