[webkit-reviews] review denied: [Bug 94580] Web Inspector: NMI: rename addMember for strings and KURL to addInstrumentedMember : [Attachment 159665] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 21 06:02:00 PDT 2012
Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 94580: Web Inspector: NMI: rename addMember for strings and KURL to
addInstrumentedMember
https://bugs.webkit.org/show_bug.cgi?id=94580
Attachment 159665: Patch
https://bugs.webkit.org/attachment.cgi?id=159665&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159665&action=review
> Source/WebCore/dom/MemoryInstrumentation.cpp:64
> + addObject(url->innerURL(), objectType);
addObject -> addInstrumentedObject, can you check why didn't the compilation
failed on this call?
More information about the webkit-reviews
mailing list