[webkit-reviews] review granted: [Bug 94484] Web Inspector: TabbedPane: measure tab widths in batches. : [Attachment 159444] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 21 05:48:01 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 94484: Web Inspector: TabbedPane: measure tab widths in batches.
https://bugs.webkit.org/show_bug.cgi?id=94484

Attachment 159444: Patch
https://bugs.webkit.org/attachment.cgi?id=159444&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159444&action=review


> Source/WebCore/inspector/front-end/ScriptsPanel.js:188
> +    this._editorContainer.setCoalescingUpdate(true);

start/endBatchUpdate or enter/exitBatchUpdate

> Source/WebCore/inspector/front-end/TabbedPane.js:395
> +	       measuringTabElement.__tab = tab;

Use map or another array?


More information about the webkit-reviews mailing list