[webkit-reviews] review granted: [Bug 94581] window.postMessage() / MessagePort.postMessage() throw wrong exception for invalid ports argument : [Attachment 159656] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 94581: window.postMessage() / MessagePort.postMessage() throw wrong
exception for invalid ports argument
https://bugs.webkit.org/show_bug.cgi?id=94581

Attachment 159656: Patch
https://bugs.webkit.org/attachment.cgi?id=159656&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
I checked it on IE. IE doesn't implement MessageChannel.

- IE and Firefox don't implement MessageChannel.

- Given that Opera throws exceptions, it makes sense for WebKit to throw some
exception.

- Although Opera throws DATA_CLONE_ERR, the spec requires to throw
INVALID_STATE_ERR. Since people wouldn't much care about the exception type, it
sounds reasonable to change WebKit to throw INVALID_STATE_ERR according to the
spec.

Let me r+ for now. But let's wait for landing the patch for one day, as someone
might have a concern.