[webkit-reviews] review denied: [Bug 94580] Web Inspector: NMI: rename addMember for strings and KURL to addInstrumentedMember : [Attachment 159639] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 94580: Web Inspector: NMI: rename addMember for strings and KURL to
addInstrumentedMember
https://bugs.webkit.org/show_bug.cgi?id=94580

Attachment 159639: Patch
https://bugs.webkit.org/attachment.cgi?id=159639&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159639&action=review


> Source/WebCore/dom/MemoryInstrumentation.h:106
> +    void addInstrumentedObject(const String&, ObjectType);

We should merge these methods into corresponding addInstrumentedObjectImpl.

> Source/WebCore/dom/MemoryInstrumentation.h:219
> +    void addInstrumentedMember(const String& string) {
m_memoryInstrumentation->addInstrumentedObject(string, m_objectType); }

Having overloaded version of addInstrumentedObjectImpl should be enough for
generic addInstrumentedMember method to work here.