[webkit-reviews] review denied: [Bug 94511] CodeGeneratorInspector.py: Generate guards for type validators : [Attachment 159526] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Thiago Marcos P. Santos
<tmpsantos at gmail.com>'s request for review:
Bug 94511: CodeGeneratorInspector.py: Generate guards for type validators
https://bugs.webkit.org/show_bug.cgi?id=94511

Attachment 159526: Patch
https://bugs.webkit.org/attachment.cgi?id=159526&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159526&action=review


A couple of nits otherwise looks good.

> Source/WebCore/inspector/CodeGeneratorInspector.py:931
> +				       if domain_guard:

The closing guard should go right after "}" and be followed by "\n\n\n" to
match the coding style when there is no guard.

> Source/WebCore/inspector/CodeGeneratorInspector.py:1338
> +				       if domain_guard:

Same here.