[webkit-reviews] review granted: [Bug 91528] Web Inspector: Embeddable Web Inspector : [Attachment 159136] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Gabriel Peal
<gpeal at google.com>'s request for review:
Bug 91528: Web Inspector: Embeddable Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=91528

Attachment 159136: Patch
https://bugs.webkit.org/attachment.cgi?id=159136&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159136&action=review


I'll fix the nits and land it for you.

>> Source/WebCore/inspector/front-end/InspectorFrontendAPI.js:149
>> +	    WebInspector.showPanel("timeline");
> 
> I think you either need to reverse the orde of these two lines to assure
timeline panel is already loaded, or use WebInspector.panel("timeline") in the
first line.

Should be WebInspector.showPanel("timeline").loadFromURL(url);

> Source/WebCore/inspector/front-end/inspector.js:417
> +    if (InspectorFrontendHost.isStub) {

It should go after WebInspector.doLoadedDone.