[webkit-reviews] review granted: [Bug 94573] [V8] Remove getToStringName() and getToStringTemplate() from V8PerIsolateData : [Attachment 159621] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 94573: [V8] Remove getToStringName() and getToStringTemplate() from
V8PerIsolateData
https://bugs.webkit.org/show_bug.cgi?id=94573

Attachment 159621: Patch
https://bugs.webkit.org/attachment.cgi?id=159621&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159621&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2964
> -    desc->Set(getToStringName(), getToStringTemplate());
> +    desc->Set(v8::String::NewSymbol("toString"),
v8::Persistent<v8::FunctionTemplate>::New(v8::FunctionTemplate::New(constructor
ToString)));

This doesn't leak the persistent handle?  m_toStringTemplate used to make us
reuse the handle.  I guess we only do this when configuration the template, so
it's bounded in any case.