[webkit-reviews] review granted: [Bug 94571] [V8] Move String related code in V8Binding to a separate file : [Attachment 159618] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 94571: [V8] Move String related code in V8Binding to a separate file
https://bugs.webkit.org/show_bug.cgi?id=94571

Attachment 159618: Patch
https://bugs.webkit.org/attachment.cgi?id=159618&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159618&action=review


> Source/WebCore/bindings/v8/V8StringResource.cpp:35
> +

I'd remove this blank line.

> Source/WebCore/bindings/v8/V8StringResource.cpp:52
> +	   String result = String::createUninitialized(length, buffer);

Does this really use int as the type for length?

> Source/WebCore/bindings/v8/V8StringResource.cpp:75
> +	   String tmp = String::createUninitialized(length, buffer);

tmp -> string ?

> Source/WebCore/bindings/v8/V8StringResource.cpp:88
> +    int length = v8String->Length();

Oh, V8 uses int for the length of a string?

> Source/WebCore/bindings/v8/V8StringResource.cpp:91
> +	   return StringImpl::empty();

Is this ok for background threads?  Typically we can't use these sorts of
functions if we're not on the main thread.