[webkit-reviews] review granted: [Bug 94557] Move free functions in test_expectations to TestExpectations class : [Attachment 159580] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 94557: Move free functions in test_expectations to TestExpectations class
https://bugs.webkit.org/show_bug.cgi?id=94557

Attachment 159580: Patch
https://bugs.webkit.org/attachment.cgi?id=159580&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
I personally have nothing against free functions and think staticmethods tend
to be a bad idea, but that is not the way adam and eric seemed to like things,
so this is fine, too.

(I think the argument is that if the function is a static method, then you can
more easily override it for testing/mocking purposes without introducing side
effects).