[webkit-reviews] review granted: [Bug 94086] [Chromium] Make the popup positioning code testable : [Attachment 159043] Patch 2

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 94086: [Chromium] Make the popup positioning code testable
https://bugs.webkit.org/show_bug.cgi?id=94086

Attachment 159043: Patch 2
https://bugs.webkit.org/attachment.cgi?id=159043&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=159043&action=review


> Source/WebCore/platform/chromium/PopupContainer.h:122
> +    static IntRect layoutAndCalculateWidgetRectInternal(IntRect
widgetRectInScreen, int targetControlHeight, const FloatRect& windowRect, const
FloatRect& screen, bool isRTL, const int rtlOffset, PopupContent*, bool&
needToResizeView);

This method has too many parameters. Probably these can be packed into a
separate class then this method can be a part of that class.