[webkit-reviews] review granted: [Bug 94480] [css3-text] Add repaint tests for -webkit-text-decoration-line : [Attachment 159549] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Bruno Abinader
<bruno.abinader at basyskom.com>'s request for review:
Bug 94480: [css3-text] Add repaint tests for -webkit-text-decoration-line
https://bugs.webkit.org/show_bug.cgi?id=94480

Attachment 159549: Patch
https://bugs.webkit.org/attachment.cgi?id=159549&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159549&action=review


> LayoutTests/ChangeLog:11
> +	   *
fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png:
Added.

Btw, the pixel output is not that of a repaint test. It looks like Qt doesn't
implement the repainting logic (see other repaint/ results on Chromium or Mac).
I would advise generating it from a Chromium or Mac build.

>
LayoutTests/fast/css3-text-decoration/repaint/repaint-text-decoration-line-expe
cted.txt:1
> +layer at (0,0) size 800x600

Technically we don't need this tree dump so we may as well disable the dumping
using:

if (window.testRunner)
    testRunner.dumpAsText(true);

>
LayoutTests/fast/css3-text-decoration/repaint/repaint-text-decoration-line.html
:26
> +	   <p><span id="test-invalid-inherit" style="text-decoration:
underline;">undecorated text</span></p>

Nit: it would be better just to use space or &nbsp so that we properly see the
line.