[webkit-reviews] review denied: [Bug 94480] [css3-text] Add repaint tests for -webkit-text-decoration-line : [Attachment 159483] Patch

Mon Aug 20 15:00:44 PDT 2012

Julien Chaffraix <jchaffraix at webkit.org> has denied Bruno Abinader
<bruno.abinader at basyskom.com>'s request for review:
Bug 94480: [css3-text] Add repaint tests for -webkit-text-decoration-line
https://bugs.webkit.org/show_bug.cgi?id=94480

Attachment 159483: Patch
https://bugs.webkit.org/attachment.cgi?id=159483&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159483&action=review

>
LayoutTests/fast/css3-text-decoration/repaint/repaint-text-decoration-line-expe
cted.txt:1
> +layer at (0,0) size 800x600

I am fine with checking this result next to the test if it is more or less
platform independent of course.

>
LayoutTests/fast/css3-text-decoration/repaint/repaint-text-decoration-line.html
:19
> +    <body onload="runRepaintTest();" style="font: Ahem 10px;
-webkit-font-smoothing: none;">

The 'font' property is not applied above, Ahem is a very recognizable font (all
the characters are squares which explains its properties). This is because your
'font' declaration is wrong: 'font-size' and 'font-family' should be inverted:

font: 10px Ahem;