[webkit-reviews] review granted: [Bug 89746] Replace isolate || bidi-override by isolate-override : [Attachment 159514] Fixes the bug

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 89746: Replace isolate || bidi-override by isolate-override
https://bugs.webkit.org/show_bug.cgi?id=89746

Attachment 159514: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=159514&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159514&action=review


LGTM

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:-1203
> -static PassRefPtr<CSSValue> renderUnicodeBidiFlagsToCSSValue(EUnicodeBidi
unicodeBidi)
> -{
> -    switch (unicodeBidi) {
> -    case UBNormal:
> -	   return cssValuePool().createIdentifierValue(CSSValueNormal);
> -    case Embed:
> -	   return cssValuePool().createIdentifierValue(CSSValueEmbed);
> -    case Plaintext:
> -	   return
cssValuePool().createIdentifierValue(CSSValueWebkitPlaintext);
> -    case Override:
> -	   return cssValuePool().createIdentifierValue(CSSValueBidiOverride);
> -    case Isolate:
> -	   return cssValuePool().createIdentifierValue(CSSValueWebkitIsolate);
> -    case OverrideIsolate:
> -    {
> -	   RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
> -	  
list->append(cssValuePool().createIdentifierValue(CSSValueBidiOverride));
> -	  
list->append(cssValuePool().createIdentifierValue(CSSValueWebkitIsolate));
> -	   return list;
> -    }
> -    }
> -    ASSERT_NOT_REACHED();
> -    return 0;
> -}
> -

Woohoo!

> LayoutTests/fast/text/bidi-override-isolate.html:-13
> -<div><span style="direction: rtl; unicode-bidi: -webkit-isolate
-webkit-isolate; unicode-bidi: isolate isolate;

Was this just a copy-paste mistake?