[webkit-reviews] review granted: [Bug 79751] Display a TextTrackCue when snap-to-lines flag is set : [Attachment 159189] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 20 13:50:55 PDT 2012
Tony Chang <tony at chromium.org> has granted Victor Carbune <victor at rosedu.org>'s
request for review:
Bug 79751: Display a TextTrackCue when snap-to-lines flag is set
https://bugs.webkit.org/show_bug.cgi?id=79751
Attachment 159189: Updated patch
https://bugs.webkit.org/attachment.cgi?id=159189&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159189&action=review
> Source/WebCore/html/track/TextTrackCue.h:62
> + virtual const AtomicString& shadowPseudoId() const;
Nit: OVERRIDE
> Source/WebCore/html/track/TextTrackCue.h:67
> + virtual RenderObject* createRenderer(RenderArena*, RenderStyle*);
Nit: OVERRIDE
> Source/WebCore/rendering/RenderTextTrackCue.h:45
> + virtual void layout();
Nit: OVERRIDE
More information about the webkit-reviews
mailing list