[webkit-reviews] review requested: [Bug 94254] [chromium] Do not allow infinite pending frames in CCFrameRateController : [Attachment 158922] Patch

[bugzilla-daemon at webkit.org]

Nat Duca <nduca at chromium.org> has asked  for review:
Bug 94254: [chromium] Do not allow infinite pending frames in
CCFrameRateController
https://bugs.webkit.org/show_bug.cgi?id=94254

Attachment 158922: Patch
https://bugs.webkit.org/attachment.cgi?id=158922&action=review

------- Additional Comments from Nat Duca <nduca at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158922&action=review


>> Source/WebKit/chromium/tests/CCThreadedTest.cpp:182
>> +	    CCProxy::implThread()->postDelayedTask(adoptPtr(swapAck), 15);
> 
> Do we want realistic swap ack delays for testing?  Or should we make this
delay shorter/zero?

How about using a CCTimer and a counter of numPending. Any time it ticks,
decrement. If numPending still greater than 0, post another tick. Then you dont
need a deque or cancel logic.

15 seems fine.