[webkit-reviews] review granted: [Bug 94493] [JSC] SerializedScriptValue::create() should throw a DataCloneError if input is an unsupported object : [Attachment 159492] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 94493: [JSC] SerializedScriptValue::create() should throw a DataCloneError
if input is an unsupported object
https://bugs.webkit.org/show_bug.cgi?id=94493

Attachment 159492: Patch
https://bugs.webkit.org/attachment.cgi?id=159492&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=159492&action=review


r+, but cq- as you need to add the new results file for
message-port-multi-expected

> LayoutTests/platform/chromium/fast/events/message-port-multi-expected.txt:-23

> -This test checks the various use cases around sending multiple ports through
MessagePort.postMessage
> -
> -On success, you will see a series of "PASS" messages, followed by "TEST
COMPLETE".
> -
> -
> -PASS channel.port1.postMessage("same port", [channel.port1]) threw exception
Error: DATA_CLONE_ERR: DOM Exception 25.
> -PASS channel.port1.postMessage("entangled port", [channel.port2]) threw
exception Error: DATA_CLONE_ERR: DOM Exception 25.
> -PASS channel.port1.postMessage("null port", [channel3.port1, null,
channel3.port2]) threw exception Error: DATA_CLONE_ERR: DOM Exception 25.
> -PASS channel.port1.postMessage("notAPort", [channel3.port1, {},
channel3.port2]) threw exception TypeError: Type error.
> -PASS channel.port1.postMessage("notAnArray", channel3.port1) threw exception
TypeError: Type error.
> -PASS channel.port1.postMessage("notASequence", [{length: 3}]) threw
exception TypeError: Type error.
> -PASS channel.port1.postMessage("largeSequence", largePortArray) threw
exception Error: DATA_CLONE_ERR: DOM Exception 25.
> -PASS event.ports is non-null and zero length when no port sent
> -PASS event.ports is non-null and zero length when empty array sent
> -PASS event.ports contains two ports when two ports sent
> -PASS event.ports contains two ports when two ports re-sent after error
> -PASS Sending host object has thrown Error: DATA_CLONE_ERR: DOM Exception 25
> -PASS send-port: transferred one port
> -PASS send-port-twice: transferred one port twice
> -PASS send-two-ports: transferred two ports
> -
> -TEST COMPLETE
> -

You've removed this -- presumably as the results are now identical, but in that
case you need to add the new results file in the right place :D