[webkit-reviews] review requested: [Bug 94510] Inspector Bar does not reflect selected font styles correctly, when multiple <div>s are selected. : [Attachment 159487] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 20 12:21:00 PDT 2012
Alice Cheng <alice_cheng at apple.com> has asked for review:
Bug 94510: Inspector Bar does not reflect selected font styles correctly, when
multiple <div>s are selected.
https://bugs.webkit.org/show_bug.cgi?id=94510
Attachment 159487: proposed patch
https://bugs.webkit.org/attachment.cgi?id=159487&action=review
------- Additional Comments from Alice Cheng <alice_cheng at apple.com>
A proposed patch to fix the problem.
Inspector Bar were not reflecting the selected font styles correctly, because
new line characters got their styles from <div> renderers, which do not reflect
their children's font styles correctly. Thus, we merge styles for new line
characters for NSAttributedString.
A TestWebkitAPI test was also included to test if the patch works.
More information about the webkit-reviews
mailing list