[webkit-reviews] review canceled: [Bug 73819] [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON : [Attachment 159393] Fixes the bug

[bugzilla-daemon at webkit.org]

Alejandro Piñeiro <apinheiro at igalia.com> has canceled Alejandro Piñeiro
<apinheiro at igalia.com>'s request for review:
Bug 73819: [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not
ROLE_PUSH_BUTTON
https://bugs.webkit.org/show_bug.cgi?id=73819

Attachment 159393: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=159393&action=review

------- Additional Comments from Alejandro Piñeiro <apinheiro at igalia.com>
Updated patch based on comment 26 review.

I didn't add a ariaHasPressedState as suggested, because as I explain in
comment 27, this is confusing with ariaHasPopup(). The method I'm adding checks
if an attribute is present, ariaHasPopup checks if has-popup attribute is true.


So I added a method called ariaPressedIsPresent (I felt that
ariaPressedAttributeIsPresent was too long).