[webkit-reviews] review denied: [Bug 94349] [Chromium] detectContentIntentAround has a misleading name : [Attachment 159142] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 20 11:43:03 PDT 2012
Adam Barth <abarth at webkit.org> has denied Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 94349: [Chromium] detectContentIntentAround has a misleading name
https://bugs.webkit.org/show_bug.cgi?id=94349
Attachment 159142: Patch
https://bugs.webkit.org/attachment.cgi?id=159142&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok. What I'd like to do here is to land this patch in two pieces:
1) The renaming, which is uncontroversial.
2) The loop in detectContentOnTouch.
Notice that this logic here is simliar to the logic related to isEventNode in
<https://bugs.webkit.org/attachment.cgi?id=158702&action=review>. It's likely
these two functions should share some of this logic since they're both trying
to figure out if something reacts to touching.
More information about the webkit-reviews
mailing list