[webkit-reviews] review granted: [Bug 94343] [Chromium] Find-in-page coordinates should use containingBlock : [Attachment 159112] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 94343: [Chromium] Find-in-page coordinates should use containingBlock
https://bugs.webkit.org/show_bug.cgi?id=94343

Attachment 159112: Patch
https://bugs.webkit.org/attachment.cgi?id=159112&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159112&action=review


> Source/WebKit/chromium/src/FindInPageCoordinates.cpp:56
> +    const RenderBlock* container = renderer->containingBlock();

ASSERT(container || renderer->isRenderView()); ?

> Source/WebKit/chromium/src/FindInPageCoordinates.cpp:104
> +	       FloatRect normalizedBoxRect =
toNormalizedRect(renderer->absoluteBoundingBoxRect(), renderer);

You don't need to pass renderer->absoluteBoundingBoxRect() here. You could
compute it in toNormalizedRect after you passed the |container| NULL-check.

> Source/WebKit/chromium/tests/WebFrameTest.cpp:978
> +    // Results 13, 12 and 14 should be one above the other in that order
because of the rowspan.

and because HTML table cells have vertical-align: middle set (CSS table cells
have vertical-align: baseline which yields to a different result).