[webkit-reviews] review granted: [Bug 94455] [V8] Move collectGarbage() from ScriptController to V8GCController : [Attachment 159368] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 94455: [V8] Move collectGarbage() from ScriptController to V8GCController
https://bugs.webkit.org/show_bug.cgi?id=94455

Attachment 159368: Patch
https://bugs.webkit.org/attachment.cgi?id=159368&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159368&action=review


> Source/WebCore/bindings/v8/V8GCController.cpp:534
> +void V8GCController::collectGarbage()

It's a bit strange that collectGarbageIfNecessary is so different from
collectGarbage.

> Source/WebCore/bindings/v8/V8GCController.cpp:538
> +    v8::Persistent<v8::Context> v8Context = v8::Context::New();

v8Context -> context