[webkit-reviews] review granted: [Bug 94211] getComputedStyle returns wrong value for CSS3 2D transformations : [Attachment 158798] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 20 10:51:34 PDT 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Alexander Shalamov
<alexander.shalamov at gmail.com>'s request for review:
Bug 94211: getComputedStyle returns wrong value for CSS3 2D transformations
https://bugs.webkit.org/show_bug.cgi?id=94211

Attachment 158798: Patch
https://bugs.webkit.org/attachment.cgi?id=158798&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=158798&action=review


> LayoutTests/fast/css/getComputedStyle/getComputedStyle-transform.html:47
> +	 for(i=1; i < 7; i++) {

Spaces around the = please. Also need 'var i'.

> LayoutTests/fast/css/getComputedStyle/getComputedStyle-transform.html:49
> +	    if ( !(Math.abs(parsedComputed[i] - parsedExpected[i]) < 0.05) )

No space before the !.


More information about the webkit-reviews mailing list