[webkit-reviews] review granted: [Bug 94435] [GTK] Split WebCore/platform into a separate library : [Attachment 159309] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 94435: [GTK] Split WebCore/platform into a separate library
https://bugs.webkit.org/show_bug.cgi?id=94435

Attachment 159309: Patch
https://bugs.webkit.org/attachment.cgi?id=159309&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159309&action=review


> Source/WebCore/GNUmakefile.am:1055
> +	-DBUILDING_WEBKIT \
> +	$(global_cppflags) \
> +	$(webcore_cppflags) \
> +	$(webcoregtk_cppflags) \
> +	$(javascriptcore_cppflags) \
> +	-fno-strict-aliasing \
> +	$(CAIRO_CFLAGS) \
> +	$(CLUTTER_CFLAGS) \
> +	$(COVERAGE_CFLAGS) \
> +	$(ENCHANT_CFLAGS) \
> +	$(GAMEPAD_CFLAGS) \
> +	$(GEOCLUE_CFLAGS) \
> +	$(GLIB_CFLAGS) \
> +	$(GSTREAMER_CFLAGS) \
> +	$(LIBSOUP_CFLAGS) \
> +	$(LIBXML_CFLAGS) \
> +	$(LIBXSLT_CFLAGS) \
> +	$(PANGO_CFLAGS) \
> +	$(SQLITE3_CFLAGS) \
> +	$(UNICODE_CFLAGS) \
> +	$(XRENDER_CFLAGS) \
> +	$(XT_CFLAGS)

Perhaps we should abstract this away into a variable for use by all WebCore
libraries?